Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong TypeError at instantiating MockAbstractEnum #332

Merged

Conversation

SZeltaat
Copy link
Contributor

@SZeltaat SZeltaat commented Aug 1, 2024

Description

We've discussed this yesterday. I think this should fix it. We now check if the expected TypeError is raised and not accidentally another TypeError.

Fixes #327

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes

@SZeltaat SZeltaat linked an issue Aug 1, 2024 that may be closed by this pull request
2 tasks
Copy link

github-actions bot commented Aug 1, 2024

Thank you so much for contributing to Blueprints! This is your Pull Request # 6 to this project.
Your contributions help thousands of engineers work more efficiently and accurately.

Now that you've created your pull request, please don't go away; take a look at the bottom of this page for the automated checks that should already be running. If they pass, great! If not, please click on 'Details' and see if you can fix the problem they've identified. A maintainer should be along shortly to review your pull request and help get it added!

Copy link
Member

@egarciamendez egarciamendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@egarciamendez egarciamendez merged commit c67c703 into main Aug 1, 2024
5 checks passed
@egarciamendez egarciamendez deleted the 327-bug-fix-test_mock_abstract_enum_is_abstract branch August 1, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐞 Bug]: Fix test_mock_abstract_enum_is_abstract
2 participants